He had two natural sons by the daughter of the captain of Blackness castle, where he was said to have been kept to secure the peace of the merse.

He m. Joan Hepburn of the family of Laughton and had a son John who predeceased him and two daughters who died young.